Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric support android #356

Closed
wants to merge 7 commits into from
Closed

Conversation

fortmarek
Copy link
Contributor

@fortmarek fortmarek commented Apr 27, 2022

Description

Draft PR for bringing Fabric support for Android.

Currently, it is possible to build the app with Fabric.

The current issues are:

  • ndkVersion must be set in such a way it's compatible with M1s (such as here). There are still some dependencies that haven't done this
    • currently, only react-native-screens does not have a new version with the fix
  • even though a view with autogenerated code is used, it's still displayed in red as if it was not migrated
    • I've replicated the issue in the RN tester app as well - see here and the screenshot below
  • react-native-reanimated is currently commented out but it should be possible to migrate since v3 supports Fabric

image

Relevant links:

  • PR for autolinking (explains some additional steps in react-native-screens)
  • Resources mentioned here

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Checklist

@fortmarek fortmarek force-pushed the fabric-support-android branch from 1a8fc9f to 6c702fe Compare May 3, 2022 15:17
@fortmarek
Copy link
Contributor Author

Closing in favor of #550

@fortmarek fortmarek closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants